Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jul 24, 2024

Closes #3
Closes synonymdev/bitkit#2107

LDK to ldk-node migration

  • Node with ldk-node instead of LDK
  • Update UI
  • OnChain Wallet via BDK
  • LN: Channel Open & Pay Invoice
  • Async ldk-node event handling + multithreading
  • Wake2pay POC

To Test

@ovitrif ovitrif self-assigned this Jul 24, 2024
@ovitrif ovitrif changed the title feat: Migrate to ldk-node WIP Migrate to ldk-node Jul 24, 2024
@ovitrif ovitrif force-pushed the feat/ldk-node branch 2 times, most recently from 6f8000c to 6cc3501 Compare July 25, 2024 01:27
@ovitrif ovitrif marked this pull request as ready for review July 25, 2024 14:43
@ovitrif ovitrif requested a review from Jasonvdb July 25, 2024 14:43
Copy link
Contributor

@Jasonvdb Jasonvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • App crashes if my esplorer server was down. Should just fail to startup the node. See the ios version. You can add our regtest server for now: https://electrs-regtest.synonym.to
  • EsploraApi not needed anymore right?

@ovitrif
Copy link
Collaborator Author

ovitrif commented Jul 26, 2024

  • App crashes if my esplorer server was down. Should just fail to startup the node. See the ios version. You can add our regtest server for now: https://electrs-regtest.synonym.to
  • EsploraApi not needed anymore right?
  1. I'm a big fan of "fail hard and early" from unix philosphy

    • For this particular case I agree we should fail silently, fixed in afe5838
    • Added regtest server in 0050ec6
  2. EsploraApi might be useful not far ahead for stability, ie. checking if it picked up best block hash before calling node.handleEvent(), see lightningdevkit/ldk-node integration tests
    I took the liberty of keeping it given its boilerplate to setup with DI in the app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android - LDK node POC Android - Migrate to ldk-node

3 participants