-
Notifications
You must be signed in to change notification settings - Fork 0
Update preactivity metadata and transfer activity handling #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f781983 to
9ee1001
Compare
|
Starting review |
|
@ben-kaufman please add this issue to the description if the PR solves it |
app/src/main/java/to/bitkit/repositories/PreActivityMetadataRepo.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- Install over an old version ✅
- reset and recover -> should recover tags ❌
tag-not-applyed.webm
- Close channel -> should display transfer activity ✅
- Open channel with external node -> should display transfer activity
onChain
- Create invoice -> attach tag -> receive payment -> Activity has tags ❌
onchain-receive.webm
- Scan qr -> attach tag -> send -> Activity has tags ✅
Lighting
- Create invoice -> attach tag -> receive payment -> Activity has tags ✅
- Scan qr -> attach tag -> send -> Activity has tags ✅
This actually shouldn't be related to this PR, since changes here are only about pre-activity, but tags in existing activities are saved in the activity itself. I'll check the issue though but maybe better in another PR.
Hmm this seems to not happen consistently, checking. |
|
@jvsena42 issue with onchain invoice should be fixed now |
…dev/bitkit-android into use-preactivity-metadata
Fix backup tags on activity edit
jvsena42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested the two failing points
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Couldn't find any issue neither in code nor in my tests.
My Tests:
- tag existing sent and received activity for onchain and for LN 🟢
- tag LN and Onchain during send 🟢
- add tags to LN and Onchain during receive, then scan with iOS & receive the payments 🟢
- backup, wipe & restore 🟢
- transfer to savings activity 🟢
- check lightning connections list & detail 🟢
- transfer to spending activity 🟢
- re-check lightning connections list & detail 🟢
- backup, wipe & restore: recheck connections, tags, activity 🟢
- open manual channel ⚫ couldn't test, encountered issues connecting to my LND peer in
bitkit-docker🤷🏻
app/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsScreen.kt
Show resolved
Hide resolved
Pull Request Review: Tag Metadata Migration to PreActivityMetadataOverviewThis PR successfully migrates tag metadata from Room database to the bitkit-core PreActivityMetadata system and enhances transfer activity handling. The code quality is generally good with comprehensive test coverage (+623 lines of new tests). However, I've identified several issues that should be addressed before merging.
|
This PR migrates the tag metadata system from Room database to bitkit-core library's PreActivityMetadata system and improves transfer activity handling throughout the app.
Similar to: synonymdev/bitkit-ios#219 synonymdev/bitkit-ios#226 synonymdev/bitkit-ios#229
Description
Migration from Room TagMetadata to PreActivityMetadata:
TagMetadataDao,TagMetadataEntity, and extensions)PreActivityMetadataRepothat interfaces withCoreService.activityfor metadata managementEnhanced Transfer Activity Handling:
isTransferflag in PreActivityMetadataActivityRepoto properly handle transfer metadata when syncing activitiesWalletRepowith better pre-activity metadata integration for transfersCoreServicenow provides activity service methods for metadata managementTesting Focus Areas:
Tag Management:
Transfer Activities:
Activity Detail Screen:
Fixes #322