Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Sep 19, 2025

This PR updates navigation to android settings into links that try to open directly the OS settings page for the Bitkit app if possible, falling back to the OS general settings page if not.

It also fixes two tiny issues in the Send flow and ensures the received transaction sheet closes the other sheets before it gets displayed, so it doesn't overlay them.

Description

Fixes

  1. feat: open settings for bitkit app if possible
  2. fix: close other sheets before showing received tx sheet
  3. fix(send): send success bottom navbar padding
  4. fix(send): nav back on fiat amount tap in confirm screen

Preview

Settings for App Send Fiat Tap Send Success Navbar Padding
fix_app_settings.mp4
fix_send_fiat_tap.mp4
fix_send_success_nav_padding.mp4

QA Notes

Tests

  1. Un+Re-install app → Scan → Don't Allow → Open Phone Settings → expect Bitkit app info
  2. Get LN funds → Receive → Pay LN invoice from other device → expect 'Transaction Received' sheet displayed → Close → expect no more 'Receive QR' sheet
  3. Send → Proceed to Pay → expect no gray border on the bottom of Send Success
  4. Send → Scan → Enter amount → on Confirm tap the big amount text → expect nav back to amount → tap big amount text to switch to fiat → on Confirm tap the big fiat amount text → expect nav back to amount again

@ovitrif ovitrif self-assigned this Sep 19, 2025
@ovitrif ovitrif requested a review from jvsena42 September 19, 2025 13:38
@ovitrif ovitrif enabled auto-merge September 19, 2025 15:09
Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on emulator

@ovitrif ovitrif merged commit a849229 into master Sep 22, 2025
29 of 43 checks passed
@ovitrif ovitrif deleted the fix/small-issues branch September 22, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants