fix: onboarding screens transition #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes transition issues on onboarding screens by adding proper background colors to their main container components and standardizing the use of a shared screen() modifier instead of manual fillMaxSize() and systemBarsPadding() calls.
- Refactored the
screen()modifier inModifiers.ktto support customWindowInsetsconfiguration - Updated all onboarding screens to use the shared
screen()modifier for consistent styling and behavior - Replaced manual layout modifiers with the centralized approach for better maintainability
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Modifiers.kt | Enhanced screen() modifier to accept optional WindowInsets parameter and use windowInsetsPadding() |
| OnboardingSlidesScreen.kt | Replaced manual layout modifiers with screen() modifier and cleaned up parameter ordering |
| IntroScreen.kt | Updated to use screen(noBackground = true) instead of manual modifiers |
| CreateWalletWithPassphraseScreen.kt | Applied screen() modifier and replaced Spacer with VerticalSpacer for consistency |
| CreateWalletScreen.kt | Used screen(insets = null) and cleaned up trailing comma formatting |
Comment on lines
197
to
+198
| modifier: Modifier = Modifier, | ||
| disclaimerText: String? = null, |
There was a problem hiding this comment.
Parameter reordering should be avoided unless necessary for API consistency. The disclaimerText parameter was moved from before modifier to after it, which could break existing callers that rely on positional arguments.
Suggested change
| modifier: Modifier = Modifier, | |
| disclaimerText: String? = null, | |
| disclaimerText: String? = null, | |
| modifier: Modifier = Modifier, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398
Description
This PR fixes the transitions issue observed on some onboarding screens, by adding background color to their main container component.
Preview
onboarding.mp4
QA Notes
Navigate thru each onboarding screen, expect no repro for the bug from the issue's recording.