Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Oct 27, 2025

Closes #386

FIGMA
ROADMAP

Description

This PR implements the Figma v58 changes on the Activity List screen, except from the drawer menu

Preview

Screen_recording_20251028_070651.webm

QA Notes

  • Used "generate test activities" from developer settings to facilitate testing
  • The Material3 DateRange calendar doesn't allow display a single month. I'll try to create a custom component on the next PR

@jvsena42 jvsena42 self-assigned this Oct 27, 2025
@jvsena42 jvsena42 marked this pull request as draft October 27, 2025 13:35
@jvsena42 jvsena42 changed the title Chore/activity list polish Activity list polish Oct 27, 2025
@ovitrif
Copy link
Collaborator

ovitrif commented Oct 27, 2025

Can you please also add a default-ish animation to the list items show/hide when filtering occurs, so the UI doesn't jump so rigid to the new list?!

Thx, had this planned but since you're working on related part, would make sense to have it here in this PR 🙏🏻

@jvsena42 jvsena42 requested a review from Copilot October 27, 2025 17:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements visual and UX improvements to the activity list screens based on the provided Figma design. The changes focus on modernizing the UI with better spacing, background styling, and a more intuitive tag filtering experience.

  • Refactors tab bar implementation with custom spacing and animations
  • Adds visual polish with card-style backgrounds and improved spacing
  • Streamlines tag filtering UX by displaying selected tags inline and removing apply/clear buttons

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ActivityListViewModel.kt Removes unused clearTags() function
CustomTabRowWithSpacing.kt Introduces new custom tab row component with animations and spacing
ActivityRow.kt Adds card background and increases icon size for better visual hierarchy
ActivityListSimple.kt Replaces horizontal dividers with consistent vertical spacing
ActivityListGrouped.kt Removes dividers and adjusts spacing for cleaner list appearance
ActivityListFilter.kt Integrates inline tag display and refactors to use custom tab component
TagSelectorSheet.kt Simplifies tag selector by removing apply/clear buttons for immediate feedback
AllActivityScreen.kt Removes complex haze effect implementation and simplifies layout structure

@jvsena42 jvsena42 marked this pull request as ready for review October 28, 2025 10:12
@jvsena42 jvsena42 requested a review from ovitrif October 28, 2025 10:31
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 💚

Added one suggestion for better UX IMHO, which is also in RN Bitkit.

And added a few nits about moving modifiers last in args list, if ok 🙏🏻 .

@jvsena42 jvsena42 requested a review from ovitrif October 28, 2025 14:02
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks for doing all the fixes and also adding the extra implementation for the nice transitions when list items are added or removed 🥇

@ovitrif ovitrif merged commit 888f50d into master Oct 28, 2025
11 checks passed
@ovitrif ovitrif deleted the chore/activity-list-polish branch October 28, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select tag screen has unnecessary Apply and Clear buttons

3 participants