-
Notifications
You must be signed in to change notification settings - Fork 1
Activity list polish #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity list polish #445
Conversation
app/src/main/java/to/bitkit/ui/screens/wallets/activity/AllActivityScreen.kt
Fixed
Show fixed
Hide fixed
|
Can you please also add a default-ish animation to the list items show/hide when filtering occurs, so the UI doesn't jump so rigid to the new list?! Thx, had this planned but since you're working on related part, would make sense to have it here in this PR 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements visual and UX improvements to the activity list screens based on the provided Figma design. The changes focus on modernizing the UI with better spacing, background styling, and a more intuitive tag filtering experience.
- Refactors tab bar implementation with custom spacing and animations
- Adds visual polish with card-style backgrounds and improved spacing
- Streamlines tag filtering UX by displaying selected tags inline and removing apply/clear buttons
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ActivityListViewModel.kt | Removes unused clearTags() function |
| CustomTabRowWithSpacing.kt | Introduces new custom tab row component with animations and spacing |
| ActivityRow.kt | Adds card background and increases icon size for better visual hierarchy |
| ActivityListSimple.kt | Replaces horizontal dividers with consistent vertical spacing |
| ActivityListGrouped.kt | Removes dividers and adjusts spacing for cleaner list appearance |
| ActivityListFilter.kt | Integrates inline tag display and refactors to use custom tab component |
| TagSelectorSheet.kt | Simplifies tag selector by removing apply/clear buttons for immediate feedback |
| AllActivityScreen.kt | Removes complex haze effect implementation and simplifies layout structure |
app/src/main/java/to/bitkit/ui/screens/wallets/activity/components/ActivityListFilter.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/activity/TagSelectorSheet.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK 💚
Added one suggestion for better UX IMHO, which is also in RN Bitkit.
And added a few nits about moving modifiers last in args list, if ok 🙏🏻 .
app/src/main/java/to/bitkit/ui/screens/wallets/activity/components/ActivityListFilter.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/activity/components/CustomTabRowWithSpacing.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/activity/TagSelectorSheet.kt
Outdated
Show resolved
Hide resolved
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for doing all the fixes and also adding the extra implementation for the nice transitions when list items are added or removed 🥇
Closes #386
FIGMA
ROADMAP
Description
This PR implements the Figma v58 changes on the Activity List screen, except from the drawer menu
Preview
Screen_recording_20251028_070651.webm
QA Notes