Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Oct 30, 2025

Closes #337

Description

This PR updates config to use the new staging RGS server on REGTEST.

Preview

regtestRgs.mp4

QA Notes

Test

  • new wallet:
  • Settings → Advanced → Rappid-Gossip-Sync
  • expect text: currently connected to {URL}.

@ovitrif
Copy link
Collaborator Author

ovitrif commented Oct 30, 2025

cc @piotr-iohk:

  1. We should be able to use the test as it was in bitkit RN e2e once this is merged ✅
  2. There is no reliable way to validate if the URL is a real RGS server, so I guess that's fine the way it is: it's a setting for techies, who should be aware of the risks…

@ovitrif ovitrif enabled auto-merge October 30, 2025 11:26
@ovitrif ovitrif requested a review from jvsena42 October 30, 2025 11:34
@ovitrif ovitrif self-assigned this Oct 30, 2025
@ovitrif ovitrif requested a review from piotr-iohk October 30, 2025 11:34
@jvsena42 jvsena42 requested a review from Copilot October 30, 2025 12:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures the application to use a staging RGS (Rapid Gossip Sync) server when running on REGTEST network, addressing issue #337. The change enables testing of RGS functionality in the regtest environment.

Key changes:

  • Added staging RGS server URL for REGTEST network configuration
  • Improved logging messages for gossip source selection
  • Refactored dispatcher creation logic for better reusability

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
app/src/main/java/to/bitkit/env/Env.kt Added staging RGS server URL for REGTEST network
app/src/main/java/to/bitkit/services/LightningService.kt Enhanced logging messages for gossip source configuration
app/src/main/java/to/bitkit/async/ServiceQueue.kt Extracted dispatcher creation into standalone function
app/src/main/java/to/bitkit/ui/settings/lightning/components/ChannelStatusView.kt Added suppression for ReturnCount lint warning
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveConfirmScreen.kt Removed unused imports

Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, except for the copilot comment

@ovitrif ovitrif requested a review from jvsena42 October 30, 2025 13:29
@ovitrif
Copy link
Collaborator Author

ovitrif commented Oct 30, 2025

Looks good for me, except for the copilot comment

Fixed and force-pushed in 81a7318

@ovitrif ovitrif merged commit 82282b5 into master Oct 30, 2025
11 checks passed
@ovitrif ovitrif deleted the feat/rgs-regtest branch October 30, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rapid Gossip Sync Server in regtest

3 participants