Skip to content

Conversation

@piotr-iohk
Copy link
Collaborator

Rel #337, synonymdev/bitkit-e2e-tests#40

Description

In order to enable @settings_11 e2e test.

Preview

QA Notes

@piotr-iohk piotr-iohk self-assigned this Oct 31, 2025
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat code with CMD + ALT + L on macOS if editing this through Android Studio.

If not, the idea is that modifiers are written on multiple lines when more than one, so

// this
modifier = Modifier.weight(1f).testTag("ConnectToHost")

// becomes:
modifier = Modifier
    .weight(1f)
    .testTag("ConnectToHost")

Ty 🙏🏻

@piotr-iohk
Copy link
Collaborator Author

I suppose, as far as the formatting style, it would be good to enforce it via CI.

@ovitrif
Copy link
Collaborator

ovitrif commented Oct 31, 2025

I suppose, as far as the formatting style, it would be good to enforce it via CI.

IIRC it used to work, don't know if this rule is not applied or it doesn't work anymore, it's been some time since I last saw any detekt lint issues on PRs.

I could look into a way to see if there's a rule or plugin for this rule to add to the detekt linter.

@jvsena42
Copy link
Member

I suppose, as far as the formatting style, it would be good to enforce it via CI.

IIRC it used to work, don't know if this rule is not applied or it doesn't work anymore, it's been some time since I last saw any detekt lint issues on PRs.

I could look into a way to see if there's a rule or plugin for this rule to add to the detekt linter.

Lets see if copilot detects

@jvsena42 jvsena42 requested a review from Copilot October 31, 2025 14:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test tags to buttons in the RGS (Rapid Gossip Sync) server settings screen to enable automated end-to-end testing, specifically for the @settings_11 e2e test case.

  • Added test tags to "Reset to Default" and "Connect to Host" buttons
  • Modified button modifiers to support multi-line chaining for better readability

@piotr-iohk piotr-iohk merged commit 9d6cbd0 into master Oct 31, 2025
11 checks passed
@piotr-iohk piotr-iohk deleted the test/settings_11 branch October 31, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants