-
Notifications
You must be signed in to change notification settings - Fork 1
Test tags to connect to RGS #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reformat code with CMD + ALT + L on macOS if editing this through Android Studio.
If not, the idea is that modifiers are written on multiple lines when more than one, so
// this
modifier = Modifier.weight(1f).testTag("ConnectToHost")
// becomes:
modifier = Modifier
.weight(1f)
.testTag("ConnectToHost")Ty 🙏🏻
|
I suppose, as far as the formatting style, it would be good to enforce it via CI. |
IIRC it used to work, don't know if this rule is not applied or it doesn't work anymore, it's been some time since I last saw any I could look into a way to see if there's a rule or plugin for this rule to add to the |
Lets see if copilot detects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds test tags to buttons in the RGS (Rapid Gossip Sync) server settings screen to enable automated end-to-end testing, specifically for the @settings_11 e2e test case.
- Added test tags to "Reset to Default" and "Connect to Host" buttons
- Modified button modifiers to support multi-line chaining for better readability
Rel #337, synonymdev/bitkit-e2e-tests#40
Description
In order to enable
@settings_11e2e test.Preview
QA Notes