Disable edit mode after editing widget #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables users to exit widget edit mode when they click to edit a specific widget's settings. The change allows the user interface to return to normal viewing mode before navigating to the widget preview/settings screen.
- Changed
disableEditMode()from private to public inHomeViewModel - Added call to
disableEditMode()when clicking to edit a specific widget
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/to/bitkit/ui/screens/wallets/HomeViewModel.kt | Made disableEditMode() function public to allow it to be called from the UI layer |
| app/src/main/java/to/bitkit/ui/screens/wallets/HomeScreen.kt | Added disableEditMode() call when clicking edit widget settings to exit edit mode before navigation |
ovitrif
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small adjustment/fix to have consistent behavior in bitkit-android and bitkit-ios. Also bitkit RN behaves currently the same.
After editing a widget the home screen now exits edit mode (previously stayed enabled on Android).
Preview
Before:
before.webm
After:
after.webm
QA Notes
synonymdev/bitkit-e2e-tests#43