Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Nov 27, 2025

FIGMA

Description

This PR applies the v59 design on receive sheet

Preview

full_test.webm
small-device.webm
cjit.webm

QA Notes

Test:

  • Small devices
  • CJIT
  • No channels -> Geoblocked -> receive lightning -> error toast
  • Has channels -> display unified invoice
  • Click on details -> change tab -> component should update when the tab changes

@jvsena42 jvsena42 self-assigned this Nov 27, 2025
@claude

This comment was marked as outdated.

@claude

This comment was marked as outdated.

@claude

This comment was marked as outdated.

@claude

This comment was marked as outdated.

Base automatically changed from feat/replace-close-with-drawer to master November 28, 2025 02:31
@claude

This comment was marked as outdated.

@jvsena42
Copy link
Member Author

jvsena42 commented Dec 3, 2025

Got a better result with LazyRow. The preview videos were updated

@jvsena42 jvsena42 marked this pull request as ready for review December 3, 2025 17:58
@jvsena42
Copy link
Member Author

jvsena42 commented Dec 3, 2025

  1. Remove the TabBar Animation Cutoff

The current TabBar (in lack of a better word, the name of the buttons at the bottom) slides back up when the sheet is dismissed, but it does it with an effect that looks more like a cut (again, slow motion is best to look at it in the recording). It shouldn't be hard to do something like iOS does when navigating to Settings, where it actually really offsets the TabBar to the bottom until it's no longer visible on the screen, then it could be removed from the composition if desired. And vice versa to bring it back.
Or simply render the sheet above the TabBar, like we used to do.

The TaBar had to be lifted to the parent compose to adapt the navigation when the TopBar was updated. Couldn't render the sheet above the tabor because of the parent composable structure. I can look for a fix in other branch to don't extend this PR too much

@ovitrif
Copy link
Collaborator

ovitrif commented Dec 3, 2025

Another request, last one:

Use Content Padding for Sliding Tabs

Should use content padding concept for sliding tabs, so that the content of each slide can look as if it bleeds outside of its inner padding.
See reference of how this is implemented in onboarding, take a closer look at the horizontal padding between the slides and the difference in Receive vs. Onboarding.

This could've also been found by comparing with iOS more meticulously 🙏🏻

Receive Android Receive iOS Onboarding Android
receiveSliding.mp4
iosSliding.mov
onboardingSliding.mp4

Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving all requests, only have a last one:

PS. Sorry for not pointing out earlier, but then this was also implied in my request to compare with iOS 🙏🏻

Once this is fixed we're ready to merge.

@jvsena42 jvsena42 mentioned this pull request Dec 3, 2025
5 tasks
@ovitrif
Copy link
Collaborator

ovitrif commented Dec 4, 2025

Actually another issue, which appeared only after the caching refactor.
When opening the Receive sheet, even on my flagship Pixel 9 Pro phone, the UI has very low FPS to the point that it's visible.

IMO this is too slow to be acceptable quality for PROD.

@jvsena42
Copy link
Member Author

jvsena42 commented Dec 4, 2025

Fixed the padding and simplified state handling (claude complicated to much, had to doit manually)

probably fixed this
#485 (comment)

Screen_recording_20251204_081338.webm
Screen_recording_20251204_075025.webm

@jvsena42 jvsena42 requested a review from ovitrif December 4, 2025 11:21
@ovitrif
Copy link
Collaborator

ovitrif commented Dec 4, 2025

Fixed the padding and simplified state handling (claude complicated to much, had to doit manually)

Was it Opus 4.5 who let us down? I merely want to understand its limits, because it's just hard, it's so powerful…

@jvsena42
Copy link
Member Author

jvsena42 commented Dec 4, 2025

Fixed the padding and simplified state handling (claude complicated to much, had to doit manually)

Was it Opus 4.5 who let us down? I merely want to understand its limits, because it's just hard, it's so powerful…

sonnet 4.5

Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

All great, maybe we could one day before release also optimize to avoid the double-flash on receive sheet open, but otherwise this is really ROCKING now 🥇

Double-flash on receive sheet open

receiveFlash.mp4

@ovitrif ovitrif merged commit c086a6c into master Dec 4, 2025
13 of 14 checks passed
@ovitrif ovitrif deleted the feat/new-receive-sheet branch December 4, 2025 13:20
@ovitrif ovitrif restored the feat/new-receive-sheet branch December 4, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants