-
Notifications
You must be signed in to change notification settings - Fork 1
Receive sheet v59 design #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
app/src/main/java/to/bitkit/ui/screens/wallets/activity/components/CustomTabRowWithSpacing.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveInvoiceUtils.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveInvoiceUtils.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Fixed
Show fixed
Hide fixed
This comment was marked as outdated.
This comment was marked as outdated.
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveInvoiceUtils.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveInvoiceUtils.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Fixed
Show fixed
Hide fixed
This comment was marked as outdated.
This comment was marked as outdated.
app/src/main/java/to/bitkit/ui/screens/wallets/activity/components/CustomTabRowWithSpacing.kt
Fixed
Show fixed
Hide fixed
This comment was marked as outdated.
This comment was marked as outdated.
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Dismissed
Show dismissed
Hide dismissed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Dismissed
Show dismissed
Hide dismissed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Dismissed
Show dismissed
Hide dismissed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Dismissed
Show dismissed
Hide dismissed
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveQrScreen.kt
Dismissed
Show dismissed
Hide dismissed
This comment was marked as outdated.
This comment was marked as outdated.
|
Got a better result with LazyRow. The preview videos were updated |
The TaBar had to be lifted to the parent compose to adapt the navigation when the TopBar was updated. Couldn't render the sheet above the tabor because of the parent composable structure. I can look for a fix in other branch to don't extend this PR too much |
|
Another request, last one: Use Content Padding for Sliding TabsShould use content padding concept for sliding tabs, so that the content of each slide can look as if it bleeds outside of its inner padding. This could've also been found by comparing with iOS more meticulously 🙏🏻
|
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving all requests, only have a last one:
PS. Sorry for not pointing out earlier, but then this was also implied in my request to compare with iOS 🙏🏻
Once this is fixed we're ready to merge.
|
Actually another issue, which appeared only after the caching refactor. IMO this is too slow to be acceptable quality for PROD. |
|
Fixed the padding and simplified state handling (claude complicated to much, had to doit manually) probably fixed this Screen_recording_20251204_081338.webmScreen_recording_20251204_075025.webm |
Was it Opus 4.5 who let us down? I merely want to understand its limits, because it's just hard, it's so powerful… |
sonnet 4.5 |
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
All great, maybe we could one day before release also optimize to avoid the double-flash on receive sheet open, but otherwise this is really ROCKING now 🥇
FIGMA
Description
This PR applies the v59 design on receive sheet
Preview
full_test.webm
small-device.webm
cjit.webm
QA Notes
Test: