fix: Primary Button width #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a layout issue with the PrimaryButton component where applying Modifier.weight(1f) with fullWidth = false didn't work as expected. The fix restructures the button by moving the gradient background and click handling from the Button's content to its modifier chain, and adjusts padding application.
Key Changes:
- Restructured button layout by moving styling from nested Box to Button modifier
- Changed click handling from Button's onClick to clickableAlpha modifier
- Adjusted padding application to be on Button instead of nested Box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #506
Description
This PR fixes the Buton width when set
Modifier.weight(1f)andfullWidth = falsePreview
Screen_recording_20251211_092703.webm
QA Notes