chore: add defensive check to skip retry when node is starting#679
Merged
chore: add defensive check to skip retry when node is starting#679
Conversation
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #663
This PR adds a defensive check to the node start retry logic to prevent unnecessary retries when the node is already starting or running.
Description
Adds a guard in the
.onFailureblock of thestart()function that checks ifnodeLifecycleState.isRunningOrStarting()before triggering a retry. If the node is in a Starting or Running state when an error occurs, the function returns success instead of retrying, which could cause issues likeNodeException.AlreadyRunning.Preview
restart.webm
restore.webm
migration.webm
QA Notes
Run unit tests
./gradlew testDevDebugUnitTest --tests LightningRepoTeststart should not retry when node lifecycle state is Startingtest passesVerify the fix