fix: decode uppercase Bitcoin addresses#708
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Collaborator
|
@jvsena42 did you test manually?! If yes, please add a marker to the tests in the PR description, like: Allows one to |
ovitrif
approved these changes
Jan 22, 2026
Collaborator
ovitrif
left a comment
There was a problem hiding this comment.
utAck.
Pending confirmation if safe to merge (if you tested it locally)
e2e succeeded anyways so it's definitely not a risk to auto-merge.
Member
Author
Yes, added the video on description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #707
This PR moves all
decode()calls toCoreServiceand adds a workaround for uppercase Bitcoin address decoding.Description
decode()method toCoreServicethat wraps the bitkitcore binding with a lowercase workarounddecode()calls fromAppViewModel,WalletRepo,LightningRepo, andAutoReadClipboardHandlerto use the centralized service methodcanDecodeClipboard()method toAppViewModelfor clipboard detectionPreview
onchain.webm
lightning.webm
clipboard.webm
QA Notes
Scan an uppercase Bitcoin address
bitcoin:BCRT1QEAN25UPQWQA4NC5EH0M23U6UHLKWR4R5DGMN5CScan a lowercase Bitcoin address
Test clipboard auto-read
Test Lightning invoice decoding