Skip to content

fix: decode uppercase Bitcoin addresses#708

Merged
jvsena42 merged 4 commits intomasterfrom
fix/decode-uppercased
Jan 22, 2026
Merged

fix: decode uppercase Bitcoin addresses#708
jvsena42 merged 4 commits intomasterfrom
fix/decode-uppercased

Conversation

@jvsena42
Copy link
Copy Markdown
Member

@jvsena42 jvsena42 commented Jan 22, 2026

Fixes #707

This PR moves all decode() calls to CoreService and adds a workaround for uppercase Bitcoin address decoding.

Description

  • Adds decode() method to CoreService that wraps the bitkitcore binding with a lowercase workaround
  • Migrates all 8 direct decode() calls from AppViewModel, WalletRepo, LightningRepo, and AutoReadClipboardHandler to use the centralized service method
  • Adds canDecodeClipboard() method to AppViewModel for clipboard detection
  • Includes TODO comment to remove the workaround when bitkit-core#66 is fixed

Preview

onchain.webm
lightning.webm
clipboard.webm

QA Notes

  1. Scan an uppercase Bitcoin address

    • Use QR scanner or paste bitcoin:BCRT1QEAN25UPQWQA4NC5EH0M23U6UHLKWR4R5DGMN5C
    • Verify it decodes correctly and navigates to send flow
  2. Scan a lowercase Bitcoin address

    • Verify normal addresses still work as expected
  3. Test clipboard auto-read

    • Copy an uppercase Bitcoin address to clipboard
    • Open app, verify clipboard detection prompt appears
  4. Test Lightning invoice decoding

    • Scan a Lightning invoice
    • Verify it decodes and shows payment details

@jvsena42 jvsena42 requested a review from ovitrif January 22, 2026 10:37
@jvsena42

This comment was marked as resolved.

@jvsena42 jvsena42 self-assigned this Jan 22, 2026
@jvsena42 jvsena42 enabled auto-merge January 22, 2026 10:45
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jan 22, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@ovitrif
Copy link
Copy Markdown
Collaborator

ovitrif commented Jan 22, 2026

@jvsena42 did you test manually?!

If yes, please add a marker to the tests in the PR description, like:
🟢 or ✅ 🙏🏻

Allows one to utAck & merge with peace of mind

Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck.

Pending confirmation if safe to merge (if you tested it locally)

e2e succeeded anyways so it's definitely not a risk to auto-merge.

@jvsena42 jvsena42 merged commit cf1c8bc into master Jan 22, 2026
13 checks passed
@jvsena42 jvsena42 deleted the fix/decode-uppercased branch January 22, 2026 13:23
@jvsena42
Copy link
Copy Markdown
Member Author

@jvsena42 did you test manually?!

If yes, please add a marker to the tests in the PR description, like: 🟢 or ✅ 🙏🏻

Allows one to utAck & merge with peace of mind

Yes, added the video on description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decoding error of uppercased address

2 participants