feat: save app and ldk logs to same file#713
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ed51c18 to
bfa9a1f
Compare
b4989ce to
778ca10
Compare
jvsena42
reviewed
Jan 23, 2026
jvsena42
reviewed
Jan 23, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
jvsena42
reviewed
Jan 23, 2026
jvsena42
reviewed
Jan 23, 2026
jvsena42
reviewed
Jan 23, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
05776ee to
762b96a
Compare
jvsena42
previously approved these changes
Jan 26, 2026
Member
jvsena42
left a comment
There was a problem hiding this comment.
Tested
- Reset and setup flow
- Single log file creation
nit: could add a method in the future for wipe old log files
Member
|
@ovitrif there are unverified commits |
762b96a to
8cfc501
Compare
Collaborator
Author
Collaborator
Author
|
Also added a change to claude workflow which is supposedly going to fix the signed commits issues |
jvsena42
approved these changes
Jan 26, 2026
Member
jvsena42
left a comment
There was a problem hiding this comment.
- Reset app
- logs displayed on correct order
2026-01-26 11:21:18.911 8132-8257 APP to.bitkit.dev W 2026-01-26 14:21:18.911 WARN [Logger.kt:60] Wiping entire logs directory… - Logger
2026-01-26 11:21:18.919 8132-8257 APP to.bitkit.dev I 2026-01-26 14:21:18.919 INFO [Logger.kt:242] Log session initialized with file path: '/data/user/0/to.bitkit.dev/files/logs/bitkit_2026-01-26_14-21-18.log' - LogSaver
2026-01-26 11:21:18.920 8132-8257 APP to.bitkit.dev I 2026-01-26 14:21:18.920 VERBOSE [Logger.kt:249] Deleting old log files… - LogSaver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #655
Summary
Both APP and LDK logs now write to the same file in chronological order.
Changes
bitkit_<timestamp>.logPreview
Testing
Or, as a dev just go to device explorer and the app's data folder and open that file in Android Studio to check.