chore: add regional locale codes to filter#722
Merged
Conversation
Member
Author
|
found a typo in
Can be updated in other PR |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Draft to fix comment |
Split locale lists to use Android resource qualifier format for localeFilters and BCP 47 format for BuildConfig.LOCALES, fixing Locale.forLanguageTag() compatibility in tests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ovitrif
approved these changes
Jan 23, 2026
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
utAck
Thanks for the prompt fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds regional locale codes to the
localeFiltersconfiguration to ensure translations for Latin American Spanish (es-419), Spain Spanish (es-ES), and Brazilian Portuguese (pt-BR) are included in the APK.Description
The
localeFiltersinbuild.gradle.ktswas missing regional variants, causing Android's resource merger to strip outvalues-b+es+419,values-es-rES, andvalues-pt-rBRdirectories from the final build. Users with devices set to these regional locales would fall back to base language translations instead of seeing region-specific strings.Preview
Screen_recording_20260123_101922.webm
QA Notes
./gradlew assembleDevReleaseunzip -p app/build/outputs/apk/dev/release/*.apk res/xml/_generated_res_locale_config.xmles-419,es-ES, andpt-BRappear in the locale config output