fix: use send-all fee for channel funding#823
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2b67324 to
3a88156
Compare
ben-kaufman
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the fee estimation for channel funding when using the full onchain balance.
Description
getMaxChannelFundableAmount()was usingcalculateTotalFee()which builds a regular transaction and fails with "Coin selection failed" when funding a channel with the entire balance (produces dust change). This switches toestimateSendAllFee()which is designed for drain transactions, matching the pattern already used ingetMaxSendAmount().Preview
No UI changes, fixes bug causing error in logs about estimating fee for full wallet balance.
QA Notes
🤖 Generated with Claude Code