Skip to content

refactor: simplify ui stability changes#862

Merged
ovitrif merged 1 commit intomasterfrom
refactor/immutable-collections-cleanup
Mar 25, 2026
Merged

refactor: simplify ui stability changes#862
ovitrif merged 1 commit intomasterfrom
refactor/immutable-collections-cleanup

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented Mar 24, 2026

This PR simplifies the immutable collections refactor (#839) by removing redundant conversions, fixing view-layer violations, and cleaning up preview data patterns.

Description

  1. Removes redundant .toImmutableList()/.toImmutableSet() calls on already-immutable data (BlocktankState fields, selectedTags)
  2. Moves view-layer conversions to source layer (ActivityDetailViewModel, SettingsViewModel, LightningConnectionsViewModel)
  3. Converts previewActivityItems to ImmutableList at source, eliminating 8 call-site conversions
  4. Replaces listOf().toImmutableList() with persistentListOf() in previews
  5. Reverts ToastQueueManager internal queue to plain List (not exposed to Compose)
  6. Extracts repeated ActivityTab.entries.toImmutableList() into file-scope vals

Preview

N/A — no visual changes, refactoring only.

QA Notes

1. Regression Checks

  1. Open the app and navigate through wallet screens (Home, Savings, Spending)
  2. Verify activity lists display correctly
  3. Open Lightning Connections settings and verify channels display in correct order
  4. Verify tag selector and activity filtering work as expected

Note for reviewer: Relying on e2e suite should be enough, PR changes were tested manually, and it's only updating coding cosmetics of previous PR.

@ovitrif ovitrif added this to the 2.2.0 milestone Mar 24, 2026
@claude

This comment has been minimized.

@ovitrif ovitrif self-assigned this Mar 24, 2026
@claude

This comment has been minimized.

@ovitrif ovitrif force-pushed the refactor/immutable-collections-cleanup branch from 00805b5 to 9297bad Compare March 24, 2026 18:23
@ovitrif ovitrif requested a review from jvsena42 March 24, 2026 18:24
@ovitrif ovitrif enabled auto-merge March 24, 2026 18:26
@claude

This comment has been minimized.

@ovitrif ovitrif force-pushed the refactor/immutable-collections-cleanup branch from 9297bad to 340a361 Compare March 24, 2026 20:01
@ovitrif ovitrif merged commit 7c65722 into master Mar 25, 2026
17 checks passed
@ovitrif ovitrif deleted the refactor/immutable-collections-cleanup branch March 25, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants