refactor: simplify ui stability changes#862
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
00805b5 to
9297bad
Compare
This comment has been minimized.
This comment has been minimized.
9297bad to
340a361
Compare
jvsena42
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the immutable collections refactor (#839) by removing redundant conversions, fixing view-layer violations, and cleaning up preview data patterns.
Description
.toImmutableList()/.toImmutableSet()calls on already-immutable data (BlocktankState fields, selectedTags)previewActivityItemstoImmutableListat source, eliminating 8 call-site conversionslistOf().toImmutableList()withpersistentListOf()in previewsToastQueueManagerinternal queue to plainList(not exposed to Compose)ActivityTab.entries.toImmutableList()into file-scope valsPreview
N/A — no visual changes, refactoring only.
QA Notes
1. Regression Checks
Note for reviewer: Relying on e2e suite should be enough, PR changes were tested manually, and it's only updating coding cosmetics of previous PR.