Merged
Conversation
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds hardware keyboard support to the custom
NumberPadcomposable, enabling digit keys (0-9), backspace, delete, and period to trigger the same input callbacks as touch. Useful when running in emulator or with a phone connected via Android Studio.The change is scoped to the primary
NumberPadcomposable only, so all 15+ screens using it (PIN entry, amount input, fee input, etc.) get keyboard support automatically.Preview
keypad_1.5x.mp4
QA Notes
1. Emulator keyboard input
2. Decimal key filtering
3. Touch input still works
4. NumPad keys (extended keyboard)