Skip to content

feat: support hardware keys in numpad#865

Merged
ovitrif merged 1 commit intomasterfrom
feat/keyboard-in-numpad
Mar 26, 2026
Merged

feat: support hardware keys in numpad#865
ovitrif merged 1 commit intomasterfrom
feat/keyboard-in-numpad

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented Mar 25, 2026

Description

This PR adds hardware keyboard support to the custom NumberPad composable, enabling digit keys (0-9), backspace, delete, and period to trigger the same input callbacks as touch. Useful when running in emulator or with a phone connected via Android Studio.

The change is scoped to the primary NumberPad composable only, so all 15+ screens using it (PIN entry, amount input, fee input, etc.) get keyboard support automatically.

Preview

keypad_1.5x.mp4

QA Notes

1. Emulator keyboard input

  • Open any screen with a numpad (e.g. Send > Amount, or PIN entry)
  • Type digits 0-9 using the computer keyboard
  • Verify digits appear as if tapping the on-screen numpad
  • Press Backspace or Delete to remove last digit
  • Verify both work identically to the on-screen delete button

2. Decimal key filtering

  • Open Send > Amount screen (uses DECIMAL numpad type)
  • Press the period key on the keyboard
  • Verify the decimal point is entered
  • Open a PIN entry screen (uses SIMPLE numpad type)
  • Press the period key
  • Verify nothing happens (period is ignored)

3. Touch input still works

  • On any numpad screen, verify tapping on-screen buttons still works as before alongside keyboard input

4. NumPad keys (extended keyboard)

  • If using an extended keyboard, verify NumPad 0-9 and NumPad dot also work

@ovitrif ovitrif self-assigned this Mar 25, 2026
@ovitrif ovitrif added this to the 2.2.0 milestone Mar 25, 2026
@ovitrif ovitrif enabled auto-merge March 25, 2026 20:47
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 25, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Copy link
Copy Markdown
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ovitrif ovitrif merged commit a246edc into master Mar 26, 2026
17 checks passed
@ovitrif ovitrif deleted the feat/keyboard-in-numpad branch March 26, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants