Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Made-with: Cursor
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ovitrif
approved these changes
Apr 30, 2026
Collaborator
ovitrif
left a comment
There was a problem hiding this comment.
tAck
Besides the listed tests, I also tested some edge cases:
- 🟢 collect changelog with multiple changelogs fragments and in multiple passes (run, then run again for new fragments)
- 🟢 collect changelog with hotfix target and a test target
- 🟢 collect changelog with multiline fragment text - it got normalised to 1-line, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #921
Description
This PR:
changelog.d/nextandchangelog.d/hotfixfragment folders.CHANGELOG.mdand preview pending fragments in the terminal.CHANGELOG.mddirectly.Preview
N/A
QA Notes
1. Collector no-op
scripts/collect-changelog.sh --target nextwith no fragments and confirm it exits cleanly.scripts/collect-changelog.sh --target hotfixwith no fragments and confirm it exits cleanly.2. Preview pending fragments
changelog.d/next/.scripts/preview-changelog.sh --target nextand confirm it renders the entry grouped by category.3. Release collection
changelog.d/next/.scripts/collect-changelog.sh --target nextand confirm it is inserted under## [Unreleased]and the fragment is deleted.Made with Cursor