Skip to content

fix: refine public Paykit contact handling#930

Merged
ovitrif merged 5 commits intocodex-public-payments-contactsfrom
codex/pr924-review-fixes
May 5, 2026
Merged

fix: refine public Paykit contact handling#930
ovitrif merged 5 commits intocodex-public-payments-contactsfrom
codex/pr924-review-fixes

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented May 5, 2026

Stacked on #924

Description

This follows up on the unresolved review comments from PR #924.

  • Moves active contact payment context into pending state (review comment).
  • Reuses shared JSON parsing (review comment).
  • Centralizes the default Bolt11 invoice lifetime for regular invoice creation (review comment).
    • doesn't update lifetime of bolt11 in paykit (contrary to that PR review comment)
  • Uses activity.contact() in contact activity filtering (review comment).
  • Renames ActivityContactTitle.kt to ContactActivityTitle.kt (review comment).
  • Refactors PublicPaykitRepoTest setup (review comment).

Preview

N/A

QA Notes

Manual Tests

  • Deleted Paykit profile
  • Created Paykit profile
  • Added Paykit contact
  • Paid LN to paykit contact
  • Received LN from paykit contact

Automated Checks

  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt

@ovitrif ovitrif changed the title [codex] address paykit review feedback fix: address paykit review feedback May 5, 2026
@ovitrif ovitrif self-assigned this May 5, 2026
@ovitrif ovitrif added this to the 2.3.0 milestone May 5, 2026
@ovitrif ovitrif changed the title fix: address paykit review feedback [codex] refine public Paykit contact handling May 5, 2026
@ovitrif ovitrif changed the title [codex] refine public Paykit contact handling fix: refine public Paykit contact handling May 5, 2026
@ovitrif ovitrif marked this pull request as ready for review May 5, 2026 13:46
@ovitrif ovitrif requested a review from ben-kaufman May 5, 2026 13:49
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 5, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@ovitrif ovitrif merged commit 8a5c573 into codex-public-payments-contacts May 5, 2026
27 checks passed
@ovitrif ovitrif deleted the codex/pr924-review-fixes branch May 5, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants