feat: add private paykit payments#941
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
…t-ui feat: add contact payment ui
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
utAck
Left the review for later, unchecked the files yet to have a way to track my progress
 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a32966803
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val result = lightningRepo.addressInfosForType( | ||
| addressType = addressType, | ||
| isChange = isChange, | ||
| startIndex = startIndex.toUInt(), | ||
| count = count.toUInt(), | ||
| ) | ||
| startIndex = startIndex, | ||
| count = count, | ||
| ).getOrThrow() |
There was a problem hiding this comment.
Switching getAddresses to lightningRepo.addressInfosForType(...).getOrThrow() makes address retrieval depend on executeWhenNodeRunning, so the address viewer now blocks/fails whenever the node is stopped or cannot reach Running (for example during startup/recovery). The previous derivation path used mnemonic-based derivation and worked without node runtime state, so this change introduces a user-visible regression where existing wallets can no longer inspect addresses in those states.
Useful? React with 👍 / 👎.
| .restoreBackup(parsed.privatePaykitHighestReservedReceiveIndexByAddressType) | ||
| .onFailure { | ||
| Logger.warn("Failed to restore private Paykit reservations", it, context = TAG) | ||
| } |
There was a problem hiding this comment.
restoreWalletBackup logs and ignores failures from restoring private Paykit reservation/link state, then still returns success (createdAt). In failure scenarios (e.g., datastore write/read issues), full restore is marked successful while private reservation ceilings are not restored, which can allow reusing previously reserved private receive indexes after recovery and silently losing private-contact state.
Useful? React with 👍 / 👎.
3 participants
Description
Implements private Paykit contact payments with iOS parity:
Preview
N/A
QA Notes
Passed local checks:
./gradlew compileDevDebugKotlin./gradlew testDevDebugUnitTest./gradlew detektgit diff --checkPassed Android emulator E2E coverage:
Received fromattributionPrivate Lightning emulator E2E reached endpoint resolution and route construction, but the local regtest run did not produce a successful payment due to LDK
RETRIES_EXHAUSTEDand receiver peer connectivity timing. The send failure path is handled and covered by unit test, but a clean private Lightning back-and-forth pass should still be repeated in QA when the regtest/LSP route is healthy.