Feat/add database wipe methods #41
Conversation
- Add activity_wipe_all() to clear all activities and tags - Add blocktank_remove_all_orders() to clear order history - Add blocktank_remove_all_cjit_entries() to clear CJIT entries - Add blocktank_wipe_all() to clear all blocktank tables - Add wipe_all_databases() for global database reset - Update tests accordingly
|
@coreyphillips Can we add @ben-kaufman as reviewer too? |
ben-kaufman
left a comment
ben-kaufman
left a comment
There was a problem hiding this comment.
I didn't go over the tests updates yet, but just sharing a few very small comments meanwhile.
Also can you please just explain the rationale/ reason behind adding this wiping option?
I can answer this, but since it surfaces an issue I want us to get better at, I will also make my case on it:
With that being said, the rationale behind adding the wipe option is to give the mobile native apps the freedom to programmatically control the file storage managed by bitkit core. |
- Add get_activity_db() helper to reduce code duplication - Ensure wipe_all_databases() requires initialized DBs - Remove unused methods: remove_all_tags(), remove_all_info() - Consolidate remove_all() into wipe_all() to remove the wrapper - Document that enum state tables persist across wipes
- Updates bindings - Bumps version to 0.1.20
This PR:
activity_wipe_all()to clear all activities and tagsblocktank_remove_all_orders()to clear order historyblocktank_remove_all_cjit_entries()to clear CJIT entriesblocktank_wipe_all()to clear all blocktank tableswipe_all_databases()for global database reset