Project setup #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jasonvdb
commented
Jul 1, 2024
Jasonvdb
commented
- Project structure
- LDK-Node
- BDK
ovitrif
approved these changes
Jul 2, 2024
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Liking everything so far, added a comment more on development guidelines than having to do with logic.
| @@ -0,0 +1,72 @@ | |||
| // | |||
Collaborator
There was a problem hiding this comment.
Can we remove these header comments in every file and still be OK per iOS/Swift dev guidelines?
Idk why we would keep them but I have no strong view and would be fine either way
Contributor
Author
There was a problem hiding this comment.
Seems to be a default xcode thing, I'll see if there is a way to remove in a future pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.