Mark closed channels activity as transfer to savings #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The transfer from spending icon is purple, could you fix it? |
…nonymdev/bitkit-ios into feat/closed-channels-activity
ovitrif
approved these changes
Nov 14, 2025
Collaborator
There was a problem hiding this comment.
ACK
Awsm work ❤️
Tests
- Existing former transfer to savings:
- It was previously shown as "Received",
- Now shows as Transfer from Spending 🟢
- New Transfer to Savings:
- Shows briefly as "Received"
- Then quickly becomes Transfer from Spending
Next Polishing tasks about this feature (roadmap: Activity…)
(now, the work on it is unlocked, was not relevant to tackle before this PR)
- Detail screen of Transfer From Spending Activity (FIGMA SLIDE):
- add cells: TO SAVINGS + FEES (PREPAID) under DATE + TIME
- Add link to Connection (Lightning Connections > Connection Detail screen)
- use purple accent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detects when a tx spends funds of a closed channel to identify the tx as a transfer from spendings to savings.
It also fixes the time estimate for the pending transfer activity.
Testing:
Enter Savings -> Transfer to spendings. Wait for the channel to open.
Enter Spendings -> Transfer to savings. Check activities and see 2 transfer activities, one into spendings and one back to spendings.
Screen.Recording.2025-11-14.at.11.58.18.AM.mov