Update transfer activity details #229
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the detection and display of onchain transactions related to Lightning channel operations. It enhances the ability to identify channel opening and closing transactions, and updates the activity details UI to properly display transfer activities between savings (onchain) and spending (Lightning) wallets.
Key Changes:
- Enhanced detection of channel-related onchain transactions by checking both closed and open channels
- Improved UI for transfer activity details with channel-specific information and proper color coding
- Refactored order-channel linking logic into a reusable extension method
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ActivityItemView.swift | Added comprehensive UI updates for transfer activities including channel detection, fee display improvements, and channel detail navigation button |
| LightningConnectionsView.swift | Refactored channel-order matching logic to use new extension method |
| TransferViewModel.swift | Simplified transfer metadata creation by removing async update logic and dedicated helper method |
| CoreService.swift | Added new method to detect channel opening transactions by matching funding transactions and Blocktank orders |
| Localizable.strings | Added new localization strings for transfer direction and prepaid fee labels |
| ChannelDetails+Extensions.swift | Created new extension with extracted and improved order-channel matching logic |
There was a problem hiding this comment.
ACK 🥇
tested:
- transfer to savings 🟢
- transfer to speding 🟢
- channel list screen 🟢
- channel detail screen 🟢
The only issues I found is what I reported via DMs, there's a temporary issue with sorting which eventually auto-fixes.
And another very minor issue is the back nav from channel details screen:
- it goes to advanced settings screen, I would expect it to go to channel list screen.
|
Issue with navigation should be fixed in the last commit. Lmk if that persists |
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
Tested open 2 channels and close both. Just found this small issue from Transifex
Fix validated 🟢 |
This PR improves the detection of onchain txs for opening channels, and updates the UI for activity details of transfer activities. (Fixes #168)
Test: Open anc close channels and ensure channel openings show in activities list as transfer from savings and channel close as transfer from spendings.
Video Demo:
Screen.Recording.2025-11-17.at.9.38.04.AM.mov