fix(ci): retry integration tests & rm ref to dead TxBumpingTests #396
+32
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 3-attempt retry with simulator reset between failures to handle flaky "Application unknown to FrontBoard" errors - Remove TxBumpingTests reference (test was removed in ae51100) - Reset simulator state before tests instead of just booting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
ovitrif
changed the title
Collaborator
Author
|
@claude address piotr's review point, give it higher weight based on the frame set by my reply to it. |
This comment has been minimized.
This comment has been minimized.
ovitrif
changed the title
Address review feedback - GitHub runners start clean, so initial simulator reset is unnecessary. Keep reset only in retry logic where it's actually needed to recover from FrontBoard errors.
ovitrif
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context
Integration tests on PR #379 (feat/t10s) failed with simulator error:
This is a flaky issue - the same PR passed earlier and failed later. The fix adds retry logic with simulator reset between attempts.
Test plan
🤖 Generated with Claude Code