Skip to content

fix(lightning): update external scorer url #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovitrif merged 1 commit into from
Feb 25, 2026
Merged

fix(lightning): update external scorer url #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Bitkit/Constants/Env.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ enum Env {

static var ldkScorerUrl: String? {
switch network {
case .bitcoin: "https://api.blocktank.to/scorer.bin"
case .bitcoin: "https://api.blocktank.to/scorer-prod"
case .signet: nil
case .testnet: nil
case .regtest: "https://api.stag0.blocktank.to/scorer"
Expand Down
2 changes: 1 addition & 1 deletion Bitkit/Services/LightningService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
)
builder.setChainSourceElectrum(serverUrl: resolvedElectrumServerUrl, config: electrumConfig)

// Set pathfinding scores source from scorer.bin file
// Set pathfinding scores source from external scorer
if let scorerUrl = Env.ldkScorerUrl {
Logger.info("Setting pathfinding scores source from scorer url: \(scorerUrl)")
builder.setPathfindingScoresSource(url: scorerUrl)
Expand Down Expand Up @@ -582,7 +582,7 @@
}

func closeChannel(_ channel: ChannelDetails, force: Bool = false, forceCloseReason: String? = nil) async throws {
guard let node else {

Check warning on line 585 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Integration Tests 

value 'node' was defined but never used; consider replacing with boolean test

Check warning on line 585 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

value 'node' was defined but never used; consider replacing with boolean test
throw AppError(serviceError: .nodeNotStarted)
}

Expand Down Expand Up @@ -957,7 +957,7 @@
onEvent?(event)

switch event {
case let .paymentSuccessful(paymentId, paymentHash, paymentPreimage, feePaidMsat):

Check warning on line 960 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Integration Tests 

immutable value 'paymentPreimage' was never used; consider replacing with '_' or removing it

Check warning on line 960 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

immutable value 'paymentPreimage' was never used; consider replacing with '_' or removing it
Logger.info("✅ Payment successful: paymentId: \(paymentId ?? "?") paymentHash: \(paymentHash) feePaidMsat: \(feePaidMsat ?? 0)")
Task {
let hash = paymentId ?? paymentHash
Expand All @@ -982,7 +982,7 @@
Logger.warn("No paymentId or paymentHash available for failed payment", context: "LightningService")
}
}
case let .paymentReceived(paymentId, paymentHash, amountMsat, feePaidMsat):

Check warning on line 985 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

immutable value 'feePaidMsat' was never used; consider replacing with '_' or removing it
Logger.info("🤑 Payment received: paymentId: \(paymentId ?? "?") paymentHash: \(paymentHash) amountMsat: \(amountMsat)")
Task {
let hash = paymentId ?? paymentHash
Expand All @@ -992,7 +992,7 @@
Logger.error("Failed to handle payment received for \(hash): \(error)", context: "LightningService")
}
}
case let .paymentClaimable(paymentId, paymentHash, claimableAmountMsat, claimDeadline, customRecords):

Check warning on line 995 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

immutable value 'customRecords' was never used; consider replacing with '_' or removing it

Check warning on line 995 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

immutable value 'claimDeadline' was never used; consider replacing with '_' or removing it
Logger.info(
"🫰 Payment claimable: paymentId: \(paymentId) paymentHash: \(paymentHash) claimableAmountMsat: \(claimableAmountMsat)"
)
Expand Down Expand Up @@ -1021,7 +1021,7 @@

if let channel {
await registerClosedChannel(channel: channel, reason: reasonString)
await MainActor.run {

Check warning on line 1024 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Integration Tests 

result of call to 'run(resultType:body:)' is unused

Check warning on line 1024 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

result of call to 'run(resultType:body:)' is unused
channelCache.removeValue(forKey: channelIdString)
}
} else {
Expand All @@ -1044,7 +1044,7 @@
Logger.error("Failed to handle transaction received for \(txid): \(error)", context: "LightningService")
}
}
case let .onchainTransactionConfirmed(txid, blockHash, blockHeight, confirmationTime, details):

Check warning on line 1047 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

immutable value 'confirmationTime' was never used; consider replacing with '_' or removing it

Check warning on line 1047 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

immutable value 'blockHash' was never used; consider replacing with '_' or removing it
Logger.info("✅ Onchain transaction confirmed: txid=\(txid) blockHeight=\(blockHeight) amountSats=\(details.amountSats)")
Task {
do {
Expand Down Expand Up @@ -1098,7 +1098,7 @@

// MARK: Balance Events

case let .balanceChanged(oldSpendableOnchain, newSpendableOnchain, oldTotalOnchain, newTotalOnchain, oldLightning, newLightning):

Check warning on line 1101 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

immutable value 'newTotalOnchain' was never used; consider replacing with '_' or removing it

Check warning on line 1101 in Bitkit/Services/LightningService.swift

View workflow job for this annotation

GitHub Actions / Run Tests 

immutable value 'oldTotalOnchain' was never used; consider replacing with '_' or removing it
Logger
.info("💰 Balance changed: onchain=\(oldSpendableOnchain)->\(newSpendableOnchain) lightning=\(oldLightning)->\(newLightning)")

Expand Down
Loading