Skip to content

fix: use send-all fee estimation for max channel fundable amount #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovitrif merged 2 commits into from
Mar 5, 2026
Merged

fix: use send-all fee estimation for max channel fundable amount #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e1896c
fix: use send-all fee estimation for max channel fundable amount
ovitrif Mar 5, 2026
20d5b15
fix(ci): enable Claude Code Review to post PR comments
ovitrif Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/claude-code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ on:
# - "src/**/*.js"
# - "src/**/*.jsx"

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

jobs:
claude-review:
# Optional: Filter by PR author
Expand Down Expand Up @@ -58,7 +62,9 @@ jobs:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
plugin_marketplaces: 'https://github.com/anthropics/claude-code.git'
plugins: 'code-review@claude-code-plugins'
prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number }}'
prompt: '/code-review:code-review --comment ${{ github.repository }}/pull/${{ github.event.pull_request.number }}'
claude_args: |
--allowedTools "Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh api:*),Bash(git log:*),Bash(git diff:*),Bash(git blame:*),Read,Glob,Grep"
# See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
# or https://code.claude.com/docs/en/cli-reference for available options

3 changes: 1 addition & 2 deletions Bitkit/ViewModels/WalletViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,9 +557,8 @@ class WalletViewModel: ObservableObject {
return fundableBalance
}
let feeRate = TransactionSpeed.normal.getFeeRate(from: feeRates)
let fee = try await lightningService.calculateTotalFee(
let fee = try await lightningService.estimateSendAllFee(
address: onchainAddress,
amountSats: fundableBalance,
satsPerVByte: feeRate
)
return fundableBalance >= fee ? fundableBalance - fee : 0
Expand Down
Loading