Skip to content

refactor: format files w/ swiftformat v0.60.1#482

Merged
ovitrif merged 1 commit intomasterfrom
chore/format
Mar 10, 2026
Merged

refactor: format files w/ swiftformat v0.60.1#482
ovitrif merged 1 commit intomasterfrom
chore/format

Conversation

@pwltr
Copy link
Copy Markdown
Contributor

@pwltr pwltr commented Mar 6, 2026

Description

Formats all files with updated SwiftFormat v0.60.1

I reviewed all changes and tested.

@pwltr pwltr changed the title refactor: format files w/ swiftformat v0.60.0 refactor: format files w/ swiftformat v0.60.1 Mar 9, 2026
@pwltr pwltr requested review from ben-kaufman, jvsena42 and ovitrif and removed request for ovitrif March 9, 2026 13:25
ben-kaufman
ben-kaufman previously approved these changes Mar 9, 2026
@ovitrif
Copy link
Copy Markdown
Collaborator

ovitrif commented Mar 9, 2026

@pwltr can we setup something similar for our binding?!
One issue I keep having is seeing how the formatting of Swift files changes again and again depending on the local tooling versions of the dev building them and it's just adding irrelevant noise to PRs...

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 9, 2026

@pwltr can we setup something similar for our binding?! One issue I keep having is seeing how the formatting of Swift files changes again and again depending on the local tooling versions of the dev building them and it's just adding irrelevant noise to PRs...

Sure, in this repo there is a pre-commit hook that runs swiftformat --lint. You could either do that or run it in CI.

ovitrif
ovitrif previously approved these changes Mar 9, 2026
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck but read all changes
Trusting author & e2e tests for runs.

Most changes are simply // to ///.

Comment thread Bitkit/Components/Core/ButtonLocationTracking.swift
Comment thread BitkitTests/BlocktankTests.swift Outdated
Comment thread BitkitTests/LdkMigration.swift
@ovitrif
Copy link
Copy Markdown
Collaborator

ovitrif commented Mar 9, 2026

@pwltr please check if I assigned correct milestone (next release), or you plan to merge this for 2.1.0.

PS. I would be totally ok with 2.1.0.

@ovitrif ovitrif added this to the 2.2.0 milestone Mar 9, 2026
@pwltr pwltr dismissed stale reviews from ovitrif and ben-kaufman via ef694fc March 10, 2026 09:57
@pwltr pwltr requested review from ben-kaufman and ovitrif March 10, 2026 09:59
@claude
Copy link
Copy Markdown

claude bot commented Mar 10, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what was changed, GitHub shows no diff vs. previous 🤔

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 10, 2026

not sure what was changed, GitHub shows no diff vs. previous 🤔

Rebased onto master where a file was deleted

@ovitrif ovitrif merged commit cac7a33 into master Mar 10, 2026
12 checks passed
@ovitrif ovitrif deleted the chore/format branch March 10, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants