Skip to content

chore: use e2e updater url for e2e builds#503

Merged
ovitrif merged 1 commit intomasterfrom
chore/e2e-updater-url
Mar 19, 2026
Merged

chore: use e2e updater url for e2e builds#503
ovitrif merged 1 commit intomasterfrom
chore/e2e-updater-url

Conversation

@piotr-iohk
Copy link
Copy Markdown
Collaborator

This PR points E2E builds to a separate updater release.json hosted in bitkit-e2e-tests, so production critical updates don't block E2E test runs.

Description

The production updater currently has critical: true for both platforms. E2E builds from master with lower build numbers hit the blocking update screen immediately, making all tests fail.

When isE2E is true, updaterUrl now resolves to:
https://github.com/synonymdev/bitkit-e2e-tests/releases/download/updater/release.json

That file has buildNumber: 0, critical: false by default, so E2E builds are never blocked. When update flow testing is needed, the E2E release.json can be updated independently.

Linked Issues/Tasks

N/A

Screenshot / Video

N/A

Made with Cursor

@piotr-iohk piotr-iohk self-assigned this Mar 19, 2026
@claude
Copy link
Copy Markdown

claude bot commented Mar 19, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ovitrif ovitrif enabled auto-merge March 19, 2026 14:26
@pwltr
Copy link
Copy Markdown
Contributor

pwltr commented Mar 19, 2026

Maybe better to get into the habit of making sure build number updates make it to master before release (and consequent updating of release.json). This is an annoyance in development as well.

@piotr-iohk
Copy link
Copy Markdown
Collaborator Author

Maybe better to get into the habit of making sure build number updates make it to master before release (and consequent updating of release.json). This is an annoyance in development as well.

I believe they do make it to master before release.json update. But if particular branch is not updated then there is an issue.
(Also if you want to build some older versions to e.g. test migration)

@ovitrif ovitrif merged commit 232112a into master Mar 19, 2026
18 of 20 checks passed
@ovitrif ovitrif deleted the chore/e2e-updater-url branch March 19, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants