chore: use e2e updater url for e2e builds#503
Merged
Conversation
Made-with: Cursor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Contributor
|
Maybe better to get into the habit of making sure build number updates make it to master before release (and consequent updating of release.json). This is an annoyance in development as well. |
Collaborator
Author
I believe they do make it to master before release.json update. But if particular branch is not updated then there is an issue. |
pwltr
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR points E2E builds to a separate updater release.json hosted in bitkit-e2e-tests, so production critical updates don't block E2E test runs.
Description
The production updater currently has
critical: truefor both platforms. E2E builds from master with lower build numbers hit the blocking update screen immediately, making all tests fail.When
isE2Eis true,updaterUrlnow resolves to:https://github.com/synonymdev/bitkit-e2e-tests/releases/download/updater/release.jsonThat file has
buildNumber: 0, critical: falseby default, so E2E builds are never blocked. When update flow testing is needed, the E2E release.json can be updated independently.Linked Issues/Tasks
N/A
Screenshot / Video
N/A
Made with Cursor