Conversation
ben-kaufman
force-pushed
the
codex/rebase-pr-527-contact-fixes-on-master
branch
from
325e4ca to
2d3784c
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d3784c9d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
piotr-iohk
left a comment
piotr-iohk
left a comment
There was a problem hiding this comment.
LGTM, it was already tested and reviewed on #530
ben-kaufman
force-pushed
the
codex/rebase-pr-527-contact-fixes-on-master
branch
from
2d3784c to
bfa43de
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Claude reviews are valid IMHO, mainly the one about changelog PR id. |
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
LGTM, validated through new Import from Pubky.
Once claude review points are handled, I would approve 🚀
* feat: add Pubky Ring auth callbacks * Update CHANGELOG with Pubky Ring auth callbacks * fix: preserve pubky session after canceled auth * fix: validate pubky auth callbacks * fix: recover from malformed pubky callbacks
ben-kaufman
force-pushed
the
codex/rebase-pr-527-contact-fixes-on-master
branch
from
bfa43de to
122070f
Compare
|
PS. force-merged (bypassing rule about signed commits, we need to resolve that for cloud AI work, not something for today though). |
3 participants
Summary
Validation
origin/masterafter rebasing: 1 commit, 6 files changed.PubkyProfileManagerTestslocally. The first run failed due to sandbox/cache permissions, the unavailableiPhone 16simulator destination, and stale Rust FFI module artifacts. A clean DerivedData retry did not complete in this environment and was stopped, so CI should be treated as the source of truth for test status.Notes
This is the clean rebased slice from the old
codex/pr-527-contact-fixesbranch. The earlier Pubky/contact work is already inmastervia PR #527; this PR carries the remaining Pubky Ring callback work from #530.