feat: facts widget v61 + OS widget#552
Conversation
…-widget-v61 # Conflicts: # BitkitWidget/PriceHomeScreenWidget.swift
…ios into feat/price-widget-v61
…/headlines-v61 # Conflicts: # Bitkit/ViewModels/WidgetsViewModel.swift
# Conflicts: # Bitkit/ViewModels/WidgetsViewModel.swift # Bitkit/Views/Widgets/WidgetEditLogic.swift # Bitkit/Views/Widgets/WidgetEditView.swift
pwltr
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3af505404
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
piotr-iohk
left a comment
piotr-iohk
left a comment
There was a problem hiding this comment.
Tested on device (iPhone 13) and sim (iPhone 17). LGTM.
|
Starting review... |
| VStack { | ||
| Spacer(minLength: 0) | ||
| FactsWidgetCompactContent(fact: viewModel.fact) | ||
| .frame(width: 163, height: 192) |
There was a problem hiding this comment.
nit: these dimensions could be extracted to a shared constant. I'll do it in other branch
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
❌ Missing changelog entry
❌ BTC icon on medium size is not changing color like on small size
✅ Text changed after 2 minutes
✅ Resize the OS widget -> Keep same text
✅ Widget options not displayed
✅ Preview working
✅ in-App widget
Simulator.Screen.Recording.-.iPhone.16.-.2026-05-18.at.08.13.37.mp4
No need for that since this PR does not target master, base PR already has a changelog entry
I don't know, it works for me as you can see from the video. Also don't see how it can differ from the code, both variants use the same image component. |
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
The color issue could be related to iOS version, I'll test and fix this behavior for all widgets in a separated branch
3 participants
Description
This PR:
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.17.-.2026-05-15.at.21.21.15.mov
QA Notes
Manual Tests
regression:widget gallery: Bitcoin Facts name and description are localized instead of showing raw keys.