feat: calculator v61 redesign & os widget#554
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c2d065d16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76f4cc3403
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f07d5c702
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Notes from testing: 1. Screen.Recording.2026-05-18.at.12.41.59.mov2. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c462f2f9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description
This PR:
Mirrors the Calculator app and OS widget work from synonymdev/bitkit-android#942.
Linked Issues/Tasks
N/A
Screenshot / Video
Not attached in this pass.
QA Notes
Manual Tests
1, decimal,0: one-decimal input shows the dimmed trailing zero placeholder in the fixed input position without cursor spacing/jump, and Bitcoin conversion updates.regression:Settings → General → Default Unit → switch Modern/Classic → Home → Calculator widget: Bitcoin amount is preserved while denomination formatting changes.Automated Checks
BitkitTests/CalculatorWidgetTests.swiftcovers calculator grouping, decimal placeholder behavior, number-pad delete/decimal caps, localized comma input normalization, symbol shortening, and classic BTC-to-sats conversion.1updated10 000 / $6.66to100 001 / $66.59.joined(separator:)helper and crashed when opening the Calculator preview;76f4cc34replaces it with direct left-to-right grouping.swiftformatpassed for changed Swift files.node scripts/validate-translations.jspassed with 0 errors.xcodebuild ... -only-testing:BitkitTests/CalculatorWidgetTests build-for-testingpassed.LDKNodeFFI.frameworksimulator install stub from DerivedData, thenxcodebuild test-without-building ... -only-testing:BitkitTests/CalculatorWidgetTestspassed with 7 tests and 0 failures.build_simforBitkitDebug on iPhone 16 Pro iOS 18.5 passed, including the Widget extension target; remaining warnings are pre-existingPubkyImage.swiftSwift 6 async lock/unlock warnings.1.0renders as continuous1.00with the placeholder zero fixed in place.Simulator 2026-05-18 005849.mp4: matched the Androidbitkit-android-5focus fix by truncating focused widgets after Calculator, hiding Add Widget while focused, anchoring the first-position Calculator with measured top padding, and removing broad implicit focus animations that caused layout jumps.build_run_simforBitkitDebug on iPhone 17 Pro iOS 26.3.1 passed after the QA fixes.test_sim -only-testing:BitkitTests/CalculatorWidgetTestspassed with 7 tests and 0 failures after the QA fixes.Run Tests,build-local, andbuild-stagingpassed; e2e jobs were still running when last checked.