Skip to content
This repository was archived by the owner on Feb 8, 2026. It is now read-only.

chore(lightning): Upgrade react-native-ldk to 0.0.96#1086

Merged
Jasonvdb merged 1 commit intomasterfrom
react-native-ldk-update
Jun 1, 2023
Merged

chore(lightning): Upgrade react-native-ldk to 0.0.96#1086
Jasonvdb merged 1 commit intomasterfrom
react-native-ldk-update

Conversation

@coreyphillips
Copy link
Copy Markdown
Collaborator

@coreyphillips coreyphillips commented Jun 1, 2023

Description

  • Upgrades react-native-ldk to 0.0.96.
  • Changes resetLdk method name to restartLdk.
  • Replaces ldk.reset() with ldk.restart() in restartLdk method.
  • Replaces setupLdk with refreshLdk in handleOrderStateChange method.
  • Replaces resetLdk() with ldk.stop() in setupLdk method.
  • Removes resetLdk() from refreshLdk method.

Type of change

  • Refactoring (improving code without creating new functionality)

Tests

  • No test

QA Notes

  • Ensure lightning channels continue to open as expected.
  • Ensure the changes do not result in new or additional crashes when opening channels or making/receiving lightning payments.
  • Lightning connectivity should be more reliable and require fewer, if any, app restarts/refreshes to interact with lightning.

Upgrades react-native-ldk to 0.0.96.
Changes resetLdk method name to restartLdk.
Replaces ldk.reset() with ldk.restart() in restartLdk method.
Replaces setupLdk with refreshLdk in handleOrderStateChange method.
Replaces resetLdk() with ldk.stop() in setupLdk method.
Removes resetLdk() from refreshLdk method.
@coreyphillips coreyphillips requested a review from Jasonvdb June 1, 2023 15:32
@Jasonvdb Jasonvdb merged commit 015313c into master Jun 1, 2023
@Jasonvdb Jasonvdb deleted the react-native-ldk-update branch June 1, 2023 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants