Skip to content
This repository was archived by the owner on Feb 8, 2026. It is now read-only.

feat(wallet): Show info toast when switching balance unit#1506

Merged
ovitrif merged 1 commit intofeat/wallet-balance-hide-toastfrom
feat/wallet-balance-switch-toast
Jan 18, 2024
Merged

feat(wallet): Show info toast when switching balance unit#1506
ovitrif merged 1 commit intofeat/wallet-balance-hide-toastfrom
feat/wallet-balance-switch-toast

Conversation

@ovitrif
Copy link
Copy Markdown
Contributor

@ovitrif ovitrif commented Jan 17, 2024

Description

Added a toast message to clarify balance unit switch actions.

Works in both balance headers:

  • Wallet overview (Home)
  • Bitcoin assets (Wallet detail)

Toast gets displayed only once: on first use.

Linked Issues/Tasks

Bitkit v45 prototype → Toast for balance unit switch (Asana)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

qemu-system-aarch64.2024-01-17.001418.mp4

QA Notes

See above video

Dev Notes

  1. I'm not sure if I broke a few rules on how we approach these things when creating the reusable useSwitchUnitAnnounced hook.
    Happy to get feedback / suggestions for alternative approaches if it feels needed.
  2. I'm targeting the PR for the hide balance toast as base branch to avoid having to do 2 redux store migrations and also because that PR isn't yet merged due to unsuccessful e2e tests. This changeset could've been just a push to that PR but then it would make it less easy to review.

@ovitrif ovitrif force-pushed the feat/wallet-balance-switch-toast branch from d2a852e to 7ca9d42 Compare January 17, 2024 15:49
@ovitrif ovitrif requested a review from pwltr January 17, 2024 15:49
@ovitrif ovitrif force-pushed the feat/wallet-balance-hide-toast branch from ce8d274 to 95628a5 Compare January 17, 2024 15:51
@ovitrif ovitrif force-pushed the feat/wallet-balance-switch-toast branch from 7ca9d42 to 581b1bf Compare January 17, 2024 15:53
@ovitrif ovitrif requested a review from coreyphillips January 17, 2024 15:54
@ovitrif ovitrif merged commit 279cab8 into feat/wallet-balance-hide-toast Jan 18, 2024
@ovitrif ovitrif deleted the feat/wallet-balance-switch-toast branch January 18, 2024 08:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants