fix(ui): fix home screen rerender causing navigation lag#2492
Conversation
485eeba to
6435c27
Compare
6435c27 to
802a1f6
Compare
coreyphillips
left a comment
There was a problem hiding this comment.
Tapping "Receive" and quickly closing the modal results in the TabBar disappearing.
Simulator.Screen.Recording.-.iPhone.16.-.2025-02-27.at.18.49.45.mp4
802a1f6 to
45b4546
Compare
This is an issue with the bottom-sheet and not caused by the changes here, although it does make it more likely to occur. I have a refactor coming for the sheets that will make it more reliable and will also solve this issue by not having to hide the TabBar at all. There are several long-standing issues with the bottom-sheet so it's a bit difficult to not break something by fixing another. I updated the code to change when it hides the TabBar to at least fix this for send/receive sheets but it will still occur when you do the same with any one of the sheets in |
Description
Fixes a rerender on the home screen caused by smelly
onFocuscode. This moves the timed/conditional bottom sheets into the home screen and extends the check in the<TabBar />so it hides properly. This significantly improves navigation responsiveness especially on Android. Also renamesWallets/index.tstoHome.tsx.Type of change
Tests