This repository was archived by the owner on Feb 8, 2026. It is now read-only.
fix(wallet): Fix Transaction Details#894
Merged
coreyphillips merged 1 commit intomasterfrom Feb 17, 2023
Merged
Conversation
Updates getInputData method to include the vout index as part of the reference object key. Added combinedAddressObj for more efficient checks when handling large number of outputs. Moved the txid check logic higher up in formatTransactions. Added replaceStoredTransactions to updateTransactions method. Added updateTransactions to the "Rescan Addresses" button.
pwltr
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
getInputDatamethod to include thevoutindex as part of the reference object key.combinedAddressObjfor more efficient checks when handling a large number of inputs/outputs.txidcheck logic higher up informatTransactions.replaceStoredTransactionstoupdateTransactionsmethod.updateTransactionsto the "Rescan Addresses" button.Notes:
getInputDatawas not taking into account thevoutindex when returning input data. So if a user had multiple inputs that were sourced from the same transaction, it would replace the information at thattx_hashindex. Only returning one instead of all the desired inputs. This would result in the miscalculation when formatting and storing the transaction for later reference.