Skip to content
This repository was archived by the owner on Feb 8, 2026. It is now read-only.

feat(wallet): Add Minimum Transaction Relay Fee Dialog#896

Merged
coreyphillips merged 1 commit intomasterfrom
min-tx-relay-fee-dialog
Feb 20, 2023
Merged

feat(wallet): Add Minimum Transaction Relay Fee Dialog#896
coreyphillips merged 1 commit intomasterfrom
min-tx-relay-fee-dialog

Conversation

@coreyphillips
Copy link
Copy Markdown
Collaborator

This PR:

  • Adds Dialog to ReviewAndSend component that alerts users when setting the min-relay fee.
  • Sets forceUpdate param to true in updateOnchainFeeEstimates when starting app.

Notes:

  • Bitkit will now grab fee estimates every time the app launches.
  • Bitkit will now present a Dialog when users have set a fee that is at or below the current minimum tx relay fee.

Adds Dialog to ReviewAndSend component that alerts users when setting the min-relay fee.
Sets forceUpdate param to true in updateOnchainFeeEstimates when starting app.
Copy link
Copy Markdown
Contributor

@limpbrains limpbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see dialog logic is broken in ReviewAndSend component - it can't show 2 dialogs one after another, but this should be fixed in another PR, I think

@coreyphillips coreyphillips merged commit 0916862 into master Feb 20, 2023
@coreyphillips coreyphillips deleted the min-tx-relay-fee-dialog branch February 20, 2023 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants