Skip to content
This repository was archived by the owner on Feb 8, 2026. It is now read-only.

fix: disable resolving profiles by default in useProfile hook#902

Merged
Nuhvi merged 1 commit intomasterfrom
fix/contacts-list-lag
Feb 23, 2023
Merged

fix: disable resolving profiles by default in useProfile hook#902
Nuhvi merged 1 commit intomasterfrom
fix/contacts-list-lag

Conversation

@Nuhvi
Copy link
Copy Markdown
Contributor

@Nuhvi Nuhvi commented Feb 22, 2023

Resolving profiles seem to block UI, which is most impactful in the Contacts List screen, disabling it by default, and enabling it while adding new contacts reduces that lag significantly

More optimizations might be needed, but I would rather test this minimum change independently from any wider refactoring.

closes #892

Screen recording (IOS simulator)

Before

Screen.Recording.2023-02-22.at.13.54.41.mov

After

Screen.Recording.2023-02-22.at.13.51.13.mov

@Nuhvi Nuhvi requested review from limpbrains and pwltr February 22, 2023 10:32
Resolving profiles seem to block UI, which is most impactful in the Contacts List screen,
disabling it by default, and enabling while adding new contacts reduces that lag significantly
@Nuhvi Nuhvi force-pushed the fix/contacts-list-lag branch from ffdfa29 to 6a54251 Compare February 22, 2023 10:49
@Nuhvi Nuhvi merged commit f461a2c into master Feb 23, 2023
@pwltr pwltr deleted the fix/contacts-list-lag branch February 23, 2023 06:16
@aldertnl
Copy link
Copy Markdown
Contributor

@nazeh 'Resolving profiles seem to block UI, which is most impactful in the Contacts List screen, disabling it by default, and enabling it while adding new contacts reduces that lag significantly'

  • Does that mean that after a wallet restore these contacts would never resolve? And that contacts would never update in general? Not sure is that is an ideal solution. Maybe we could load the Contacts list screen UI, and after that populate the contacts data (resolve these) asynchronously.

@Nuhvi
Copy link
Copy Markdown
Contributor Author

Nuhvi commented Feb 23, 2023

@aldertnl It will resolve if you go to their contact page, not in the contact list.

This can be solved easily by resolving profiles once after restoring from the backup. But it is not the case now!

@Nuhvi
Copy link
Copy Markdown
Contributor Author

Nuhvi commented Feb 23, 2023

@aldertnl the correct solution here is to backup the cached profiles in the Redux store, and restore that when the app is restored.

@coreyphillips what is the status there and do you need help?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Opening the contacts view after tapping on the contacts icon is still a bit sluggish

3 participants