This repository was archived by the owner on Feb 8, 2026. It is now read-only.
fix: disable resolving profiles by default in useProfile hook#902
Merged
fix: disable resolving profiles by default in useProfile hook#902
Conversation
Resolving profiles seem to block UI, which is most impactful in the Contacts List screen, disabling it by default, and enabling while adding new contacts reduces that lag significantly
ffdfa29 to
6a54251
Compare
pwltr
approved these changes
Feb 22, 2023
Contributor
|
@nazeh 'Resolving profiles seem to block UI, which is most impactful in the Contacts List screen, disabling it by default, and enabling it while adding new contacts reduces that lag significantly'
|
Contributor
Author
|
@aldertnl It will resolve if you go to their contact page, not in the contact list. This can be solved easily by resolving profiles once after restoring from the backup. But it is not the case now! |
Contributor
Author
|
@aldertnl the correct solution here is to backup the cached profiles in the Redux store, and restore that when the app is restored. @coreyphillips what is the status there and do you need help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving profiles seem to block UI, which is most impactful in the Contacts List screen, disabling it by default, and enabling it while adding new contacts reduces that lag significantly
More optimizations might be needed, but I would rather test this minimum change independently from any wider refactoring.
closes #892
Screen recording (IOS simulator)
Before
Screen.Recording.2023-02-22.at.13.54.41.mov
After
Screen.Recording.2023-02-22.at.13.51.13.mov