fix: excessive rerendering on home screen #2075
Conversation
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
| dispatch(updateUi({ isOnline: true })); | ||
| updateExchangeRates(); | ||
| // FIXME: this runs too often | ||
| // updateExchangeRates(); |
There was a problem hiding this comment.
This needs to be moved to another place. Not sure why but this fires even when connection status did not change.
limpbrains
left a comment
limpbrains
left a comment
There was a problem hiding this comment.
This is strange. Maybe it was because we are mutating state where we should not
I think this is purely about selectors. Docs are not very clear but looks like |
|
Nothing to specifically test. See #2052 (comment) |
Description
The Home screen and several components lower in the tree were rerendering way too many times because of bad selectors. Reselect's
createSelectoris not doing its job correctly so I'm adding a customcreateShallowEqualSelectorthat does correct shallow equality checking needed for some larger selectors. Also we should not memoize selectors withcreateSelectorby default. Should be assessed case by case whether it's needed. For most simple value lookups it is not needed.Linked Issues/Tasks
#2052
Type of change
Tests
QA Notes
Make sure components still rerender when they should.