Skip to content

Conversation

@coreyphillips
Copy link
Collaborator

This PR:

  • Updates scanning logic to provide more context when an error occurs.
  • Sets up lnurl logic and adds custom notifications in the meantime.
  • Adds getLightningBalance method to utils/lightning.ts.
  • Makes source & sdk params optional in processInputData method.

Notes:

  • While not perfect, I wanted to provide users with a bit more context when an error occurs prior to the next release.
    • In this iteration, more descriptive notifications will appear when an error occurs while scanning.
      • For example, if a user does not have enough sats to pay an invoice, a notification will appear to state this fact along with how many more sats are required to fulfill the invoice.
    • In the event there are multiple requests in a given qrcode/invoice, the error messages will be appended in the order they occur and appear in the notification message.
    • Notification messages were also added to the following lnurl scan events (lnurlPay, lnurlAuth, lnurlWithdraw & lnurlChannel).
    • The sdk param was made optional so that processInputData method can be called in a given function without having to pass sdk through several other methods when we know we will not need to process slashtags data.

Updates scanning logic to provide more context when an error occurs.
Sets up lnurl logic and adds custom notifications in the meantime.
Adds getLightningBalance method to utils/lightning.ts.
Makes source & sdk params optional in processInputData method.
@coreyphillips coreyphillips merged commit 281ea74 into master Dec 31, 2022
@coreyphillips coreyphillips deleted the improve-scanner-errors branch December 31, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants