-
Notifications
You must be signed in to change notification settings - Fork 26
feat(wallet): Add Address Viewer #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds the AddressViewer component to the Advanced Settings list. Updates getUtxos method in electrum.ts. Creates listUnspentAddressScriptHashes & getAddressUtxos methods in electrum.ts. Updates getPrivateKey method in utils/wallet/index.ts.
limpbrains
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removes unnecessary awaits. Adds timer to address generation function. Updates utxoIsSelected method.
|
Regarding this, when attempting to check balances of addresses using a network that the wallet is not currently set to, the Address Viewer will switch to that network in the background so that it can utilize the correct electrum server for the balance request. I'm not too worried about it since this feature of the viewer is only enabled when dev settings are on, but this is most likely something we'll need to fix when switching networks in general. |

This PR:
AddressViewercomponent to the Advanced Settings list.getUtxosmethod inelectrum.ts.listUnspentAddressScriptHashes&getAddressUtxosmethods inelectrum.ts.getPrivateKeymethod inutils/wallet/index.ts.getUtxosthat would prevent certain address types from being returned in the utxo array.Notes/Included Functionality: