feat(wallet): Add Minimum Transaction Relay Fee Dialog #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Dialog to ReviewAndSend component that alerts users when setting the min-relay fee. Sets forceUpdate param to true in updateOnchainFeeEstimates when starting app.
limpbrains
approved these changes
Feb 20, 2023
Contributor
limpbrains
left a comment
limpbrains
left a comment
There was a problem hiding this comment.
I can see dialog logic is broken in ReviewAndSend component - it can't show 2 dialogs one after another, but this should be fixed in another PR, I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
DialogtoReviewAndSendcomponent that alerts users when setting the min-relay fee.forceUpdateparam to true inupdateOnchainFeeEstimateswhen starting app.Notes: