feat: add calculate send all fee for onchain#68
Merged
Conversation
ovitrif
approved these changes
Mar 2, 2026
…ll-fee # Conflicts: # Package.swift # bindings/python/pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnchainPayment::calculate_send_all_fee()as the fee-estimation counterpart ofsend_all_to_address(), allowing callers to preview the mining fee for a drain transactionbefore broadcasting.
retain_reservesflag to matchsend_all_to_addressbehavior (anchor channelreserve handling).
Motivation
calculate_total_fee()fails when called withamount_satsequal to the total UTXO value,because the internal
ExactRetainingReservevalidation adds a fee buffer that exceeds theavailable value. The existing
InsufficientFundsfallback incalculate_total_feealso failsbecause it forwards the caller's specific
utxos_to_spend, which conflicts with BDK'sdrain_wallet()mode.calculate_send_all_feesolves this by directly usingAllRetainingReserve/AllDrainingReservewithutxos_to_spend: None, matching howsend_all_to_addressbuildsthe actual transaction.
Integration
Test plan
calculate_send_all_fee_matches_actual— funds a node, estimates fee, sends viasend_all_to_address, asserts estimated fee equals actual feeonchain_send_all_retains_reserve— verifies retain vs drain fee estimation with openanchor channels