This repository was archived by the owner on Feb 9, 2026. It is now read-only.
Conversation
Implements reorg checks where needed. Sets tx as unconfirmed when a reorg or missing tx is detected. Adds unconfirmedTxs to lightning-manager.ts. Removes confirmedTxs from lightning-manager.ts. Removes leftover payWithRoute methods. Bumps version to 0.0.98.
Jasonvdb
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
unconfirmedTxstolightning-manager.ts.confirmedTxsfromlightning-manager.tsalong with its corresponding checks.payWithRoutemethods.0.0.98.When a watch transaction or watch output is seen as having one or more confirmation it is added to the
unconfirmedTxsarray. These txs will continue to be monitored until they reach 6 or more confirmations. If at any point a transaction is reorg'd by having a lower height than the previous known height or is no longer in the chain/mempoolldk.setTxUnconfirmedis called. In these rare scenarios, LDK will force-close and the user will have to wait roughly 143-150 blocks for their funds to be returned.