Skip to content
This repository was archived by the owner on Feb 9, 2026. It is now read-only.

fix(lightning): Limit lm.start Calls#182

Merged
Jasonvdb merged 1 commit intomasterfrom
limit-lm-start-calls
Oct 17, 2023
Merged

fix(lightning): Limit lm.start Calls#182
Jasonvdb merged 1 commit intomasterfrom
limit-lm-start-calls

Conversation

@coreyphillips
Copy link
Copy Markdown
Collaborator

@coreyphillips coreyphillips commented Oct 17, 2023

This PR:

  • Prevents simultaneous calls to lm.start.
  • Will allow for multiple calls if a new account name is passed to the lm.start method.
  • Adds isStarting, pendingStartPromises & previousAccountName to lightning-manager.ts.
  • Adds resolveAllPendingStartPromises & handleStartError to lightning-manager.ts.
  • Updates start method in lightning-manager.ts accordingly.

@coreyphillips
fix(lightning): Limit lm.start Calls
bd610af 
Prevents simultaneous calls to lm.start.
@Jasonvdb Jasonvdb merged commit 50b625d into master Oct 17, 2023
@Jasonvdb Jasonvdb deleted the limit-lm-start-calls branch October 17, 2023 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Jasonvdb Jasonvdb Jasonvdb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coreyphillips @Jasonvdb