Skip to content

Example Project Update #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jasonvdb merged 2 commits into from
Jun 2, 2022
Merged

Example Project Update #3

Jasonvdb merged 2 commits into from
Jun 2, 2022

Conversation

@coreyphillips
Copy link
Collaborator

@coreyphillips coreyphillips commented May 29, 2022

This PR:

  • Updates example project.
  • Updates eslint rules and resolves linting errors throughout project.

@coreyphillips
Updated example project.
f2e6437 
Updated linting rules and resolved errors throughout project.
@coreyphillips coreyphillips requested a review from Jasonvdb May 29, 2022 18:13
@Jasonvdb
Copy link
Contributor

Jasonvdb commented Jun 2, 2022

Was getting TypeError: undefined is not an object (evaluating '_ref.seed') error when starting so fixed by adding default param here

@Jasonvdb Jasonvdb merged commit 0bc1c34 into master Jun 2, 2022
@Jasonvdb Jasonvdb deleted the example-and-linting-updates branch June 2, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Jasonvdb Jasonvdb Jasonvdb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coreyphillips @Jasonvdb