Skip to content

Closing channels and log files #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coreyphillips merged 5 commits into from
Jul 19, 2022
Merged

Closing channels and log files #32

coreyphillips merged 5 commits into from
Jul 19, 2022

Conversation

@Jasonvdb
Copy link
Contributor

@Jasonvdb Jasonvdb commented Jul 19, 2022 •
edited
Loading

  • Cooperatively close channels
  • Force close channels if peer is offline by passing force: true
  • Swift and kotlin will write all LDK logs to a file if passed through with ldk.setLogFilePath(logPath)
  • Example app shows LDK logs in modal

Note: This PR doesn't solve #31

@Jasonvdb Jasonvdb force-pushed the close-sweep-channels branch from fe67c36 to 87682af Compare July 19, 2022 18:56
@Jasonvdb Jasonvdb requested a review from coreyphillips July 19, 2022 18:58
@coreyphillips coreyphillips merged commit ea3c161 into master Jul 19, 2022
@coreyphillips coreyphillips deleted the close-sweep-channels branch July 19, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coreyphillips coreyphillips coreyphillips approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jasonvdb @coreyphillips