-
-
Notifications
You must be signed in to change notification settings - Fork 3
Update index error handling #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improve error feedback for better easier error handling.
|
I think this will change behaviour of e.g., falsey values that are not a number are passed through. |
|
I've updated the error handling to include falsey values. |
Falsey values should also fail.
wooorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this’ll be good with a couple of changes!
Co-Authored-By: Titus <tituswormer@gmail.com>
Co-Authored-By: Titus <tituswormer@gmail.com>
Co-Authored-By: Titus <tituswormer@gmail.com>
|
Thanks for the suggestions, I've committed them. |
|
Released! |
I've updated the error handling for invalid indexes.
The new version is compatible with the types I will be submitting shortly.
Error messages are now narrowed to the specific error.