Skip to content

Update index error handling #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 8, 2019
Merged

Update index error handling #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
badb677
Update error handling
Roang-zero1 Nov 16, 2019
242c3ea
Add tests for invalid indices
Roang-zero1 Dec 7, 2019
a6c4b78
Fix error handling for falsey values
Roang-zero1 Dec 7, 2019
1b13ffe
Update index.js
Roang-zero1 Dec 8, 2019
6560bd6
Update index.js
Roang-zero1 Dec 8, 2019
4499299
Update index.js
Roang-zero1 Dec 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,17 @@ function findAllAfter(parent, index, test) {
children = parent.children
length = children.length

if (index && index.type) {
if (index === undefined || index === null) {
throw new Error('Expected positive finite index or child node')
} else if (index && typeof index !== 'number') {
index = children.indexOf(index)
if (index === -1) {
throw new Error('Expected child node')
}
}

if (isNaN(index) || index < 0 || index === Infinity) {
throw new Error('Expected positive finite index or child node')
if (typeof index !== 'number' || index < 0 || index === Infinity) {
throw new Error('Expected positive finite number as index')
}

while (++index < length) {
Expand Down
20 changes: 17 additions & 3 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,29 @@ test('unist-util-find-all-after', function(t) {
assert.throws(function() {
findAllAfter({type: 'foo', children: []})
}, /Expected positive finite index or child node/)
}, 'should fail without index')

t.doesNotThrow(function() {
assert.throws(function() {
findAllAfter({type: 'foo', children: []}, -1)
}, /Expected positive finite index or child node/)
}, /Expected positive finite number as index/)

assert.throws(function() {
findAllAfter({type: 'foo', children: []}, Infinity)
}, /Expected positive finite number as index/)

assert.throws(function() {
findAllAfter({type: 'foo', children: []}, false)
}, /Expected positive finite number as index/)

assert.throws(function() {
findAllAfter({type: 'foo', children: []}, '')
}, /Expected positive finite number as index/)

assert.throws(function() {
findAllAfter({type: 'foo', children: []}, {type: 'bar'})
}, /Expected positive finite index or child node/)
}, 'should fail without index')
}, /Expected child node/)
}, 'should fail with invalid index')

t.doesNotThrow(function() {
assert.throws(function() {
Expand Down