Skip to content

Add extensions to local imports of files in types #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2022
Merged

Add extensions to local imports of files in types #14

merged 1 commit into from
Sep 6, 2022

Conversation

@remcohaszing
Copy link
Member

@remcohaszing remcohaszing commented Sep 6, 2022

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This is needed for the node16 module resolution.

The use of "module": "node16" in this project’s tsconfig.json has been withheld because of davidbonnet/astring#646.

@remcohaszing
Add relative type import extensions
2938376 
This is needed for the `node16` module resolution.

The use of `"module": "node16"` in this project’s `tsconfig.json`  has been
withheld because of davidbonnet/astring#646.
@remcohaszing remcohaszing added 🐛 type/bug This is a problem ☂️ area/types This affects typings labels Sep 6, 2022
@remcohaszing remcohaszing requested a review from a team September 6, 2022 17:13
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 6, 2022
@wooorm
Copy link
Member

wooorm commented Sep 6, 2022

We should likely be able to switch to https://github.com/syntax-tree/estree-util-to-js, which helps with JSX.

Would astring still be blocking then?

@wooorm wooorm changed the title Add relative type import extensions Add extensions to local imports of files in types Sep 6, 2022
@wooorm wooorm merged commit cac704c into syntax-tree:main Sep 6, 2022
@github-actions

This comment has been minimized.

Sign in to view
@remcohaszing
Copy link
Member Author

remcohaszing commented Sep 6, 2022

Using estree-util-to-js would yield the same issue, because it re-exports astring types.

@wooorm wooorm added the 💪 phase/solved Post is done label Sep 6, 2022
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 6, 2022
@wooorm
Copy link
Member

wooorm commented Sep 6, 2022

Released in 3.0.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm wooorm approved these changes

Assignees

No one assigned

Labels

☂️ area/types This affects typings 💪 phase/solved Post is done 🐛 type/bug This is a problem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remcohaszing @wooorm